Repository navigation
fix(library): new singles and albums with a dead cover link get their cover from Deezer - #1880
Merged
Merged
Conversation
… cover from Deezer
github-actions
Bot
added
bug
Preview image:
|
Performance: Nothing is slower than main.50,336 tracks, 2 alternating rounds per side, lower quartiles.
|
lklynet
added a commit
that referenced
this pull request
Nov 13, 2026
…k to the base edition (#1881) After #1880, a few new albums still had no cover. Deezer had all of them, but the fallback asked for the wrong thing: - It picked a Deezer artist by name first and took the first match. "Avatar" hit a 2-fan artist instead of the Swedish band, and "Girlband" hit "Girl Band" instead of GIRLBAND!. - It then matched the artist's albums by title and picked "ENCORE (Extended Version)", which Deezer lists without a cover until it comes out. Now the fallback searches Deezer's albums for the artist and title in one request, and only accepts a result whose artist and title both match and that has a cover. If an edition like "(Extended Version)" has no art, it searches once more without the bracketed part and uses the base album's cover. It asks Deezer whenever the release-group path found no artwork, and a Deezer error is retried in 5 minutes instead of being remembered as missing for a day. Proof: the album-artwork test (a same-name decoy artist, a dead cover link, an edition without art) fails on `main`. Calling the new lookup against real Deezer returns the right cover for all three albums that were still missing. `pnpm run check`, `pnpm test`, and `pnpm run test:integration` pass. Reviewed with sol-loop: 1 round with gpt-6.1-sol on high. Sol verdict: approved Created with Claude Opus 5.5 in Claude Code (T3 Code), reviewed by gpt-6.1-sol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of Library albums showed no cover. Two cases, both common for new singles from playlist syncs:
Now, when an album has no release group or its release-group cover won't download, Aurral asks Deezer for that artist and album title. Deezer is only asked when the release-group lookup hasn't already asked it, so there are no duplicate calls and no new BrainzMash calls. A cover found this way is saved like any other, including the
cover.jpgbeside Aurral-downloaded tracks, so the lookup runs once.Proof: one new case in
album-artwork.test.tscovers both, failing onmain. The file now stubs Deezer with an empty catalogue so other tests don't reach it.pnpm run check,pnpm test(perf baseline unchanged), andpnpm run test:integrationpass.Created with Claude Opus 5.5 in Claude Code (T3 Code).